Skip to content

Improve XLASynNodeImpl str() format #4216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2022
Merged

Improve XLASynNodeImpl str() format #4216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eae1356
Improve XLASynNodeImpl str() format
vanbasten23 Nov 17, 2022
e128b88
fix the linter
vanbasten23 Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/cpp/test_symint.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ TEST(SymintTest, TestXLASymNodeImplStr) {
torch::lazy::NodePtr size_node =
torch::lazy::MakeNode<SizeNode>(expand_value, 0);
c10::SymNode symint_node = c10::make_intrusive<XLASymNodeImpl>(size_node);
ASSERT_EQ(symint_node.get()->str(), "Static bound: 2");
ASSERT_EQ(symint_node.get()->str(), "<=2");
}

} // namespace cpp_test
Expand Down
3 changes: 1 addition & 2 deletions torch_xla/csrc/tensor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1990,8 +1990,7 @@ c10::SymNode XLASymNodeImpl::floordiv(const c10::SymNode& other) {
}

std::string XLASymNodeImpl::str() {
return "Static bound: " +
std::to_string(DimCast(node().get())->getStaticValue());
return "<=" + std::to_string(DimCast(node().get())->getStaticValue());
}

torch::lazy::hash_t XLATensor::GetGraphHash(
Expand Down