Catch info from metadata #4724
Merged
Catch info from metadata #4724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackCaoG
reviewed
Mar 7, 2023
torch_xla/experimental/tpu.py
Outdated
|
|
||
| accelerator_type = tpu_env[xenv.ACCELERATOR_TYPE] | ||
| if version() == 4: | ||
| if tpu_env['ACCELERATOR_TYPE'].startswith('v4') or tpu_env['ACCELERATOR_TYPE'].startswith('v5'): |
There was a problem hiding this comment.
@will-cromar what's the right place to add a test for this one? I felt like we had similar tests somwehre.
There was a problem hiding this comment.
The relevant unit test is here:
xla/test/pjrt/test_experimental_tpu.py
Line 90 in 18674da
Can we just do tpu.version() >= 4 here?
There was a problem hiding this comment.
Thanks, updated
suexu1025
requested changes
Mar 15, 2023
will-cromar
requested changes
Mar 16, 2023
ManfeiBai
added a commit
that referenced
this pull request
Mar 28, 2023
This reverts commit 4d67a04.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update code to catch info from metadata