Skip to content

Add _softmax to ATen XLA type #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2019
Merged

Add _softmax to ATen XLA type #547

merged 1 commit into from
Apr 2, 2019

Conversation

asuhan
Copy link
Contributor

@asuhan asuhan commented Apr 1, 2019

It's just a wrapper of softmax.

@asuhan
Add _softmax to ATen XLA type
b317d46 
It's just a wrapper of softmax.
@asuhan asuhan requested a review from ailzhang April 1, 2019 17:55
@asuhan
Copy link
Contributor Author

asuhan commented Apr 1, 2019

We need this for BERT.

@asuhan asuhan requested a review from dlibenzi April 1, 2019 22:41
@asuhan asuhan merged commit 989f271 into master Apr 2, 2019
@asuhan asuhan deleted the asuhan/softmax_wrapper branch April 2, 2019 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlibenzi dlibenzi dlibenzi approved these changes

@ailzhang ailzhang Awaiting requested review from ailzhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asuhan @dlibenzi