fix batch_size insistent in report #7820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysiraichi
reviewed
Aug 9, 2024
|
|
||
| # real batch_size can be updated after load_model, need to update | ||
| # so the config can be reflected in the report. | ||
| experiment_config['batch_size'] = experiment.batch_size |
There was a problem hiding this comment.
Wouldn't it be better if we move this to the main thread, so that Run with --model-config=.... logs also reflect in that batch size?
There was a problem hiding this comment.
My concern is that moving this to the main thread will not update the batch_size if we run with the single test command for example:
python experiment_runner.py \
--suite-name=torchbench \
--experiment-config='{"accelerator":"TPU","xla":"PJRT","dynamo":"openxla","test":"eval","torch_xla2":null,"xla_flags":null,"keep_model_data_on_cuda":0}' \
--model-config='{"model_name":"BERT_pytorch"}'
In this case, the report is still bach_size:None.
qihqi
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update batch_size in the metric report after loading the model.