Skip to content

Wire in dense gather. #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2019
Merged

Wire in dense gather. #921

merged 1 commit into from
Aug 12, 2019

Conversation

dlibenzi
Copy link
Collaborator

No description provided.

@dlibenzi dlibenzi requested a review from taylanbil August 11, 2019 09:25
taylanbil
taylanbil reviewed Aug 12, 2019
View reviewed changes
@taylanbil
Copy link
Collaborator

I'm not familiar w/ dense/sparse gather, but this lgtm. Did you test?

@dlibenzi
Copy link
Collaborator Author

I'm not familiar w/ dense/sparse gather, but this lgtm. Did you test?

Yes, tests are green on my machine.
The code is here:

https://github.com/tensorflow/tensorflow/blob/13e631e9f7b4e70f50c58e961b56bb9e81fe1ff3/tensorflow/compiler/xla/client/lib/slicing.cc#L143

@dlibenzi dlibenzi merged commit b04b86e into master Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylanbil taylanbil taylanbil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlibenzi @taylanbil