Skip to content

Clean up quantized matmul condition code #9506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025
Merged

Clean up quantized matmul condition code #9506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions torch_xla/experimental/pallas_kernels/quantized_matmul_kernel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,16 +70,16 @@ def matmul_kernel(
assert quantize_activation
assert q_x_scratch is not None
assert x_scale_scratch is not None
quant = out_idx == 0
quant = (out_idx == 0)
else:
assert q_x_scratch is None
assert x_scale_scratch is None
quant = quantize_activation

if save_acc:
assert acc_scratch is not None
is_first_step = in_idx == 0
is_last_step = in_idx == n_in - 1
is_first_step = (in_idx == 0)
is_last_step = (in_idx == (n_in - 1))
else:
assert acc_scratch is None
is_first_step = True
Expand Down
Loading