Deduplicate GetXlaTensors()
function.
#9518
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deduplicates
GetXlaTensors()
.Previously, there were 2 functions in the repository with the same name, similar functionality, different signature:
init_python_bindings.cpp
aten_xla_bridge.h
want_all=true
, it behaved similarly toGetXlaTensors()
Therefore, this PR introduces the following key changes:
GetXlaTensors(..., /* want_all= */ true)
call sites withGetValueOrThrow(bridge::GetXlaTensors(...))
GetXlaTensors()
toCollectXlaTensors()
, avoiding functions with different semantics to have the same nameCollectXlaTensors()
to have only thewant_all=false
behavior, removingwant_all
flag from the function parameters