Rename MaybeThrow to OkOrThrow.
#9561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysiraichi
force-pushed
the
ysiraichi/rename-status-throw-function
branch
from
ed4ee46 to
fa11be7
Compare
ysiraichi
changed the base branch from
ysiraichi/status-crash-report
to
master
ysiraichi
added a commit
that referenced
this pull request
Sep 30, 2025
Since pytorch/pytorch#162659 was merged again, we observed that `SiLUBackward` C++ test was crashing with a segmentation fault #9561. Not only that, but TPU tests started failing because `flax` 0.12.0 (old: 0.11.2) started pulling a newer `jax` 0.7.2 (old: 0.7.1). - Old CI build: [link](https://github.com/pytorch/xla/actions/runs/17931468317/job/51089906800) - Recent broken CI build: [link](https://github.com/pytorch/xla/actions/runs/18008717023/job/51550125217?pr=9655) Therefore, in this PR: - Pin `flax` to version 0.11.2 - Skip `SiLUBackward` C++ test Additionally, it also installs `jax` and `libtpu` using the CI PyTorch/XLA wheels metadata instead of using PyPI wheels metadata. This should avoid other version compatibilities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames
MaybeThrowfunction toOkOrThrow. This change follows previous naming in #9552, whereOkOrDiewas introduced. Rationale: such a name shows intention more clearly.