Skip to content

Conversation

kyuyeunk
Copy link
Contributor

Fix a bug when using t2j with fp8 dtypes.

@qihqi qihqi self-requested a review August 20, 2025 19:48
@qihqi qihqi enabled auto-merge (squash) August 20, 2025 19:49
auto-merge was automatically disabled August 20, 2025 21:47

Head branch was pushed to by a user without write access

@kyuyeunk kyuyeunk force-pushed the add_support_for_fp8 branch from 541944d to b3c87ff Compare August 20, 2025 21:47
@kyuyeunk kyuyeunk requested a review from qihqi August 20, 2025 21:57
@kyuyeunk kyuyeunk force-pushed the add_support_for_fp8 branch from b3c87ff to e826c62 Compare August 20, 2025 22:56
@qihqi qihqi enabled auto-merge (squash) August 21, 2025 18:45
@kyuyeunk
Copy link
Contributor Author

Hi @qihqi, it seems like the test is failing due to some unrelated changes. Is it possible to just merge it?

@qihqi
Copy link
Collaborator

qihqi commented Aug 22, 2025

@kyuyeunk Please rebase on HEAD it should be gone.

auto-merge was automatically disabled August 22, 2025 20:14

Head branch was pushed to by a user without write access

@kyuyeunk kyuyeunk force-pushed the add_support_for_fp8 branch from e826c62 to 44c269e Compare August 22, 2025 20:14
@kyuyeunk
Copy link
Contributor Author

@kyuyeunk Please rebase on HEAD it should be gone.

Thanks! I have rebased on HEAD.

@qihqi qihqi enabled auto-merge (squash) August 22, 2025 21:05
@qihqi qihqi merged commit f8b44e2 into pytorch:master Aug 22, 2025
24 checks passed
@kyuyeunk kyuyeunk deleted the add_support_for_fp8 branch August 22, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants