Skip to content

Conversation

ysiraichi
Copy link
Collaborator

@ysiraichi ysiraichi commented Sep 2, 2025

This PR removes the CUDA specific code from the benchmarks directory. This is in line with the CUDA deprecation that started on release 2.8.

Key Changes:

  • Removed the keep_model_data_on_cuda parameter
    • Used in combination with zero-overhead CUDA to XLA:CUDA data movement, removed in #9598 and #9603
  • Deleted llama.py, nightly.sh, run_benchmark.sh, run_single_graph_bm.sh, and run_top_tier_bm.sh
    • All of them ran benchmarks comparing PyTorch Inductor with XLA:CUDA, specifically

Copy link
Collaborator

@zhanyong-wan zhanyong-wan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive!

@ysiraichi ysiraichi merged commit 8ff2ee6 into master Sep 3, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants