Move torch ops error message tests into a new file. #9622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysiraichi
force-pushed
the
ysiraichi/move-error-message-tests
branch
from
5922160 to
ee84cdd
Compare
zhanyong-wan
approved these changes
Sep 8, 2025
zhanyong-wan
approved these changes
Sep 9, 2025
ysiraichi
force-pushed
the
ysiraichi/move-error-message-tests
branch
2 times, most recently
from
41a580d to
d582be6
Compare
ysiraichi
force-pushed
the
ysiraichi/move-error-message-tests
branch
from
d582be6 to
298e5c4
Compare
ysiraichi
added a commit
that referenced
this pull request
Sep 15, 2025
This PR fixes #9622, which extracted error messages checks out of `test_operations.py` into `test_ops_error_message.py`. There were a few problems with that PR, namely: - `unittest.main()` wasn't being run: although calling `python -m pytest` runs it automatically, running it without the `pytest` module did nothing - `onlyOnCPU()` would error if `PJRT_DEVICE` environment variable wasn't set - `test_ops_error_message.py` wasn't being run on CI This PR fixes all the aforementioned PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In summary, this PR:
test_ops_error_message.pyexpecttestas a dependency inrequirements.infileexpecttestto those tests, so as to avoid copy-and-pasting error messagesThe introduction of
expecttestPython package was, in fact, implicit to our tests because of the following PyTorch testing library import:xla/test/test_operations.py
Line 33 in f6ff30d