Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate dask delays to pyninjotiff #1052

Merged
merged 5 commits into from
Feb 25, 2020

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Jan 30, 2020

This PR makes satpy take advantage of the new features in pyninjotiff

  • Tests passed
  • Passes flake8 satpy

@mraspaud mraspaud added enhancement code enhancements, features, improvements component:writers labels Jan 30, 2020
@mraspaud mraspaud self-assigned this Jan 30, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 88.081% when pulling a23fb85 on mraspaud:fix-ninjotiff-writer into e25415b on pytroll:master.

@coveralls
Copy link

coveralls commented Jan 30, 2020

Coverage Status

Coverage increased (+0.03%) to 88.103% when pulling 60397ac on mraspaud:fix-ninjotiff-writer into e25415b on pytroll:master.

@codecov
Copy link

codecov bot commented Feb 5, 2020

Codecov Report

Merging #1052 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1052      +/-   ##
=========================================
+ Coverage   88.08%   88.1%   +0.02%     
=========================================
  Files         191     191              
  Lines       29412   29435      +23     
=========================================
+ Hits        25907   25934      +27     
+ Misses       3505    3501       -4
Impacted Files Coverage Δ
satpy/writers/ninjotiff.py 60% <100%> (+0.62%) ⬆️
satpy/tests/writer_tests/test_ninjotiff.py 100% <100%> (+2.17%) ⬆️
satpy/tests/compositor_tests/__init__.py 99.61% <0%> (-0.01%) ⬇️
satpy/readers/scmi.py 82.91% <0%> (ø) ⬆️
satpy/tests/reader_tests/test_agri_l1.py 99.01% <0%> (ø) ⬆️
satpy/tests/test_writers.py 98.05% <0%> (ø) ⬆️
satpy/scene.py 89.91% <0%> (+0.17%) ⬆️
satpy/writers/__init__.py 86.02% <0%> (+0.27%) ⬆️
satpy/tests/reader_tests/test_seviri_l2_bufr.py 94.11% <0%> (+0.36%) ⬆️
satpy/readers/seviri_l2_bufr.py 93.9% <0%> (+1.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e25415b...60397ac. Read the comment docs.

@mraspaud mraspaud marked this pull request as ready for review February 25, 2020 13:46
@mraspaud mraspaud merged commit 9035bf0 into pytroll:master Feb 25, 2020
@mraspaud mraspaud deleted the fix-ninjotiff-writer branch February 25, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:writers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants