Fix writing float geotiffs #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhoese
force-pushed
the
bugfix-float-geotiff
branch
from
2fcfaa9
to
b0c15ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff origin/develop **/*py | flake8 --diffPreviously there would be an exception if an ImageWriter tried to create an image with no enhancements since for most image formats this doesn't make sense (an 8-bit PNG without being scaled properly?). This PR makes it possible for users to tell satpy to not enhance the image and let the writer see try to use the un-enhanced image. Behavior is undefined for other writers, but typically the data is clipped and converted to the necessary array data type before attempting to write it to disk. Side note: the fully documented above isn't the best way to document it (I just added it to the docstring of the writer class), but we don't have any official per-writer documentation at the moment so I thought this would be ok.