Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reader for GMS-5 VISSR data #2117

Merged
merged 67 commits into from
Jun 26, 2023
Merged

Add reader for GMS-5 VISSR data #2117

merged 67 commits into from
Jun 26, 2023

Conversation

sfinkens
Copy link
Member

@sfinkens sfinkens commented May 31, 2022 •
edited
Loading

Add reader for GMS-5 VISSR data in VISSR archive format.

TODO:

  • Geolocation
  • Calibration
  • Daskified
  • Metadata (orbital & time parameters)
  • Mask space pixels (can be disabled)
  • FSFile support for gzip decompression
  • Area def with uniform sampling
  • Unit tests with real files
  • Documentation

Notes:

  • I'm not NOW happy with the navigation performance :)
  • Adds numba as new dependency
  • Tests with unstable dependencies fail, because numba requires numpy<=1.24. But numpy-1.25 is already on their roadmap.

Examples:

VIS IR1
vissr_VIS vissr_IR1
vissr_VIS_resampled vissr_IR1_resampled

@sfinkens
Add GMS-5 VISSR reader
daefbac
@sfinkens
Add prediction interpolation
1a35b4a
@sfinkens
Fix jitclasses with jit disabled
966148c
@sfinkens
Fix computation of scanning angles
bc19af2
@sfinkens
Refactor static -> projection parameters
d94a6ae
@sfinkens
Refactor prediction_time -> prediction_times
d78be5f
@sfinkens
Refactor cont -> continuous
dbb2a39
@sfinkens
Refactor xp/yp -> x_sample/y_sample
6866b86
@sfinkens
Reorder classes
c212b3f
@sfinkens
Simplify interpolation
a9c3b5e
@sfinkens
Refactor predicted navigation parameters
a7a3128
@sfinkens
Update get_area_def
793be49
@sfinkens
Add skeleton for file handler tests
a71b975
@sfinkens
Read navigation parameters from the header
6b025ef
@sfinkens
Add lat/lon coords to dataset
2d3eed2
@sfinkens
Tidy up tests
178f76e
@sfinkens
Refactor single-pixel navigation
0a6ae3c 
Use njit decorator instead of jitclass
@sfinkens
Refactor image navigation
16ae238 
Use njit decorator instead of jitclass
@sfinkens
Add lon/lat coordinates to yaml definition
a7ffd2f
stickler-ci
stickler-ci reviewed May 31, 2022
View reviewed changes
satpy/readers/gms5_vissr_l1b.py Outdated Show resolved Hide resolved
satpy/readers/gms5_vissr_l1b.py Outdated Show resolved Hide resolved
satpy/readers/gms5_vissr_l1b.py Outdated Show resolved Hide resolved
satpy/readers/gms5_vissr_l1b.py Outdated Show resolved Hide resolved
satpy/readers/gms5_vissr_l1b.py Outdated Show resolved Hide resolved
satpy/tests/reader_tests/test_gms5_vissr_l1b.py Outdated Show resolved Hide resolved
satpy/tests/reader_tests/test_gms5_vissr_l1b.py Outdated Show resolved Hide resolved
satpy/tests/reader_tests/test_gms5_vissr_l1b.py Outdated Show resolved Hide resolved
satpy/tests/reader_tests/test_gms5_vissr_l1b.py Outdated Show resolved Hide resolved
satpy/tests/reader_tests/test_gms5_vissr_l1b.py Outdated Show resolved Hide resolved
@mraspaud
Copy link
Member

mraspaud commented Jun 1, 2022

What is the status of this? Could this be merged, since it still can be useful to some, and then open new PRs to add calibration, daskification, etc?

@sfinkens
Copy link
Member Author

@mraspaud I'm gonna continue here this autumn probably. But it's a good idea to merge this version and add more features later. I'll try to get this into a merge-able state in the upcoming weeks.

@sfinkens sfinkens marked this pull request as ready for review June 6, 2023 09:46
@sfinkens sfinkens requested a review from simonrp84 June 6, 2023 09:47
@sfinkens sfinkens self-assigned this Jun 6, 2023
@mraspaud
Copy link
Member

@sfinkens this looks good! I'm just wondering if the 3 gms5 files should be in their own subpackage under readers?

@sfinkens
Copy link
Member Author

Good idea, done!

@sfinkens sfinkens added this to the v0.43.0 milestone Jun 21, 2023
mraspaud
mraspaud reviewed Jun 21, 2023
View reviewed changes
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, clean code and good structure. Just a few comments/questions inline.

satpy/tests/reader_tests/gms/test_gms5_vissr_navigation.py Outdated Show resolved Hide resolved
satpy/readers/gms/gms5_vissr_navigation.py Show resolved Hide resolved
satpy/readers/gms/gms5_vissr_l1b.py Show resolved Hide resolved
@simonrp84
Copy link
Member

Just had a quick look through the code, all looks good to me!

@sfinkens
Copy link
Member Author

Just had a quick look through the code, all looks good to me!

Thanks for taking the time!

mraspaud
mraspaud approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mraspaud mraspaud added enhancement code enhancements, features, improvements component:readers labels Jun 26, 2023
@mraspaud mraspaud merged commit c3ea08e into pytroll:main Jun 26, 2023
@sfinkens sfinkens deleted the feature-vissr branch October 18, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stickler-ci stickler-ci stickler-ci left review comments

@simonrp84 simonrp84 simonrp84 approved these changes

@mraspaud mraspaud mraspaud approved these changes

@djhoese djhoese Awaiting requested review from djhoese djhoese is a code owner

Assignees

@sfinkens sfinkens

Labels
component:readers enhancement code enhancements, features, improvements
Projects
PCW Spring 2023
Status: Done
Milestone
v0.43.0
Development

Successfully merging this pull request may close these issues.
5 participants
@sfinkens @mraspaud @coveralls @simonrp84 @stickler-ci