-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize seviri_l2_grib.yaml file and add more documentation to seviri_l1b_native.py #2474
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2474 +/- ##
=======================================
Coverage 94.82% 94.82%
=======================================
Files 339 339
Lines 49400 49400
=======================================
Hits 46845 46845
Misses 2555 2555
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming things were just reordered and not changed, this looks good to me.
Is this ready for merge? |
@djhoese from my side ready to merge. |
This PR re-orders the
files_types
anddatasets
in seviri_l2_grib.yaml-file in aplhabetical order in order to find things easier. Also, comments are added for clarity and resource links added.Furthermore, the documentation for
seviri_l1b_native
-reader is updated with examples and more introduction to matchseviri_l1b_hrit
-documentation.Last, typos and some PyCharm complaints are fixed in a few other files.
docs
built without warnings on my machine.