Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize seviri_l2_grib.yaml file and add more documentation to seviri_l1b_native.py #2474

Merged
merged 5 commits into from
May 11, 2023

Conversation

sjoro
Copy link
Collaborator

@sjoro sjoro commented May 10, 2023

This PR re-orders the files_types and datasets in seviri_l2_grib.yaml-file in aplhabetical order in order to find things easier. Also, comments are added for clarity and resource links added.

Furthermore, the documentation for seviri_l1b_native-reader is updated with examples and more introduction to match seviri_l1b_hrit-documentation.

Last, typos and some PyCharm complaints are fixed in a few other files. docs built without warnings on my machine.

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #2474 (f541574) into main (5e2cb88) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2474   +/-   ##
=======================================
  Coverage   94.82%   94.82%           
=======================================
  Files         339      339           
  Lines       49400    49400           
=======================================
  Hits        46845    46845           
  Misses       2555     2555           
Flag Coverage Δ
behaviourtests 4.42% <0.00%> (ø)
unittests 95.45% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/readers/utils.py 92.95% <ø> (ø)
satpy/readers/seviri_base.py 100.00% <100.00%> (ø)
satpy/readers/seviri_l1b_hrit.py 90.49% <100.00%> (ø)
satpy/readers/seviri_l1b_native.py 86.40% <100.00%> (ø)

@djhoese djhoese added component:readers cleanup Code cleanup but otherwise no change in functionality labels May 10, 2023
Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming things were just reordered and not changed, this looks good to me.

@djhoese djhoese changed the title Reorganize seviri_l2_grib.yaml file for easier reading. Reorganize seviri_l2_grib.yaml file for easier reading May 10, 2023
@sjoro sjoro closed this May 11, 2023
@sjoro sjoro reopened this May 11, 2023
@sjoro sjoro changed the title Reorganize seviri_l2_grib.yaml file for easier reading Reorganize seviri_l2_grib.yaml file and add more documentation to seviri_l1b_native.py May 11, 2023
@djhoese
Copy link
Member

djhoese commented May 11, 2023

Is this ready for merge?

@djhoese djhoese self-assigned this May 11, 2023
@sjoro
Copy link
Collaborator Author

sjoro commented May 11, 2023

@djhoese from my side ready to merge.

@djhoese djhoese merged commit f3cde7c into pytroll:main May 11, 2023
@sjoro sjoro deleted the fix-seviri-l2-grib-yaml branch May 12, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code cleanup but otherwise no change in functionality component:readers documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants