Fix eccodes package names in setup.py, update documentation for setting up development environment. #2478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es-package names.
sjoro
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2478 +/- ##
=======================================
Coverage 94.82% 94.82%
=======================================
Files 339 337 -2
Lines 49400 49406 +6
=======================================
+ Hits 46845 46851 +6
Misses 2555 2555
Flags with carried forward coverage won't be shown. Click here to find out more. |
Pull Request Test Coverage Report for Build 4958679338
💛 - Coveralls |
djhoese
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the package names for
eccodesinsetup.py. Old package nameseccodes-pythonandpython-eccodesare deprecated, see:https://pypi.org/project/eccodes-python/
https://confluence.ecmwf.int/display/UDOC/How+to+install+ecCodes+with+Python+bindings+in+conda+-+ecCodes+FAQ
For added confusion both
eccodesandpython-eccodesare available in conda-forge and can be installed, but the new installation of the package should be:The
condainstallation installs the C/Fortran library and the command line tools,pipinstalls the python bindings to thiseccodes-library. For this reason the documentation is also updated to reflect the correct procedure.The new docs built without warnings on my machine.