Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NWCSAF reading for NOAA-21 #2481

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Conversation

ninahakansson
Copy link
Contributor

@ninahakansson ninahakansson commented May 15, 2023

Reading NWCSAF products for NOAA-21 failed. I got the error message:
ValueError: Could not find dataset named cmic_reff_pal in ancillary variables for dataset 'cloud_drop_effective_radius' but I think it was unrelated to reading NOAA-21 data. I updated the dictionary with VIIRS and METimage satellites.

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

Without it I got error message:

ValueError: Could not find dataset named cmic_reff_pal in ancillary variables for dataset 'cloud_drop_effective_radius'
@adybbroe
Copy link
Contributor

Why not add support for JPSS-3/NOAA-22 as well now that you are add it?
We know that the name will be NOAA-22 if JPSS-3 launch is successful. It is supposed to be launched in 2027, but I guess it is likely it will be delayed or postponed a bit, but anyway it is still quite "soon".

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #2481 (92dcc10) into main (bc9c089) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2481   +/-   ##
=======================================
  Coverage   94.82%   94.82%           
=======================================
  Files         337      337           
  Lines       49406    49406           
=======================================
  Hits        46851    46851           
  Misses       2555     2555           
Flag Coverage Δ
behaviourtests 4.43% <ø> (ø)
unittests 95.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/readers/nwcsaf_nc.py 82.00% <ø> (ø)

@coveralls
Copy link

coveralls commented May 15, 2023

Pull Request Test Coverage Report for Build 4989180744

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.397%

Totals Coverage Status
Change from base Build 4960323333: 0.0%
Covered Lines: 46964
Relevant Lines: 49230

💛 - Coveralls

@ninahakansson ninahakansson marked this pull request as ready for review May 22, 2023 08:40
@djhoese
Copy link
Member

djhoese commented Jun 14, 2023

RTD is failing because of:

/home/docs/checkouts/readthedocs.org/user_builds/satpy/conda/2481/lib/python3.10/site-packages/satpy/enhancements/__init__.py:docstring of satpy.enhancements._jma_true_color_reproduction:6: ERROR: Unexpected indentation.
/home/docs/checkouts/readthedocs.org/user_builds/satpy/conda/2481/lib/python3.10/site-packages/satpy/enhancements/__init__.py:docstring of satpy.enhancements._jma_true_color_reproduction:7: WARNING: Block quote ends without a blank line; unexpected unindent.

I think this was fixed in main so a merge with main might fix it.

Copy link
Contributor

@adybbroe adybbroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But RTD is failing for some strange reason?
satpy.enhancements._jma_true_color_reproduction:6: ERROR: Unexpected indentation
Maybe someone else has an idea?
Also, a question: Do we need this JPSS-1 entry? Looks a bit odd having it when we don't have anything for 2 & 3?

@djhoese
Copy link
Member

djhoese commented Jun 14, 2023

Ok I found the commit:

0ae0b78

No need to merge main. If this is ready then feel free to merge @adybbroe.

@adybbroe adybbroe merged commit 9415ad9 into pytroll:main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants