-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NWCSAF reading for NOAA-21 #2481
Conversation
Without it I got error message: ValueError: Could not find dataset named cmic_reff_pal in ancillary variables for dataset 'cloud_drop_effective_radius'
Why not add support for JPSS-3/NOAA-22 as well now that you are add it? |
Codecov Report
@@ Coverage Diff @@
## main #2481 +/- ##
=======================================
Coverage 94.82% 94.82%
=======================================
Files 337 337
Lines 49406 49406
=======================================
Hits 46851 46851
Misses 2555 2555
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Pull Request Test Coverage Report for Build 4989180744
💛 - Coveralls |
RTD is failing because of:
I think this was fixed in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But RTD is failing for some strange reason?
satpy.enhancements._jma_true_color_reproduction:6: ERROR: Unexpected indentation
Maybe someone else has an idea?
Also, a question: Do we need this JPSS-1
entry? Looks a bit odd having it when we don't have anything for 2 & 3?
Reading NWCSAF products for NOAA-21 failed. I got the error message:
ValueError: Could not find dataset named cmic_reff_pal in ancillary variables for dataset 'cloud_drop_effective_radius' but I think it was unrelated to reading NOAA-21 data. I updated the dictionary with VIIRS and METimage satellites.
AUTHORS.md
if not there already