Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix angle caching not handling a specific type of irregular chunking #2485

Merged
merged 1 commit into from
May 17, 2023

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented May 16, 2023

In #2483 @simonrp84 ran into a case where chunks where the last chunk is larger than the first chunk fail to save to zarr in dask, but are supposed to be caught and rechunked automatically by Satpy. They weren't being rechunked which was causing an error. This PR fixes that.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4996174977

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0004%) to 95.399%

Totals Coverage Status
Change from base Build 4995535188: 0.0004%
Covered Lines: 46983
Relevant Lines: 49249

💛 - Coveralls

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #2485 (1be309b) into main (bc9c089) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2485   +/-   ##
=======================================
  Coverage   94.82%   94.83%           
=======================================
  Files         337      337           
  Lines       49406    49425   +19     
=======================================
+ Hits        46851    46870   +19     
  Misses       2555     2555           
Flag Coverage Δ
behaviourtests 4.43% <0.00%> (-0.01%) ⬇️
unittests 95.45% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/modifiers/angles.py 99.17% <100.00%> (+<0.01%) ⬆️
satpy/tests/modifier_tests/test_angles.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@djhoese
Copy link
Member Author

djhoese commented May 17, 2023

Tested locally with Simon's help. Works. Merging...

@djhoese djhoese merged commit 9a772e2 into pytroll:main May 17, 2023
@djhoese djhoese deleted the bugfix-angle-cache-oddchunks2 branch May 17, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cacheing doesn't work with scn.crop
2 participants