Change logic for ninjogeotiff gradient/axisintercept tags #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the ninjogeotiff writer, change the logic for deciding whether or not to set the tags AxisIntercept and Gradient. Previously, those were always set, unless the image had mode RGB or RGBA. With this change, those tags are set only if the image has mode L and LA and PhysicUnit is not set to N/A. This commit also makes a small bugfix in a data fixture in the test routine, that leads to a few reference values changing slightly. This reflects no change in functionality, but only between the fixtures and the test functions. Adapt documentation to reflect that NinJo 7 is now out and about.
mraspaud
reviewed
May 23, 2023
djhoese
approved these changes
May 24, 2023
Codecov Report
@@ Coverage Diff @@
## main #2491 +/- ##
=======================================
Coverage 94.83% 94.83%
=======================================
Files 337 337
Lines 49430 49451 +21
=======================================
+ Hits 46875 46896 +21
Misses 2555 2555
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Pull Request Test Coverage Report for Build 5076940443
💛 - Coveralls |
|
CodeScene is wrong or unreasonable. It complains my method has increased to 92 lines of code, but I count only 33 physical or 13 logical lines of code (unless we include the docstring, which can't be right). The number of logical lines of code stays the same in this PR, and I have actually factored out some functionality. I do not agree with CodeScenes conclusion that the code health has decreased. |
|
code health is good enough for me, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the ninjogeotiff writer, change the logic for deciding whether to set the tags AxisIntercept and Gradient. Previously, those were always set, unless the image had mode RGB or RGBA. With this change, those tags are set only if the image has mode L and LA and PhysicUnit is not set to N/A.
This commit also makes a small bugfix in a data fixture in the test routine, that leads to a few reference values changing slightly. This reflects no change in functionality, but only between the fixtures and the test functions.
Adapt documentation to reflect that NinJo 7 is now out and about.