-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to clip negative ABI radiances #2499
Conversation
@simonrp84 cc |
Pull Request Test Coverage Report for Build 5346533956
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## main #2499 +/- ##
==========================================
+ Coverage 94.84% 94.85% +0.01%
==========================================
Files 337 337
Lines 49571 49689 +118
==========================================
+ Hits 47016 47134 +118
Misses 2555 2555
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Everythings seems ready for a final review ;) |
Oh I just realized the configuration documentation should probably be updated too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'm good with this. Thanks for getting this done. @ghiggi have you tested it it for your use case and does it work as expected? @simonrp84 any other concerns?
@mraspaud milestone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just some minor comments inline
Co-authored-by: Martin Raspaud <martin.raspaud@smhi.se>
Co-authored-by: Martin Raspaud <martin.raspaud@smhi.se>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A single suggestion from me, otherwise looks OK.
Out of interest, does GOES-ABI suffer a similar problem at the top end? I know SEVIRI has issues with large radiance out-of-range for the big depth of the sensor (which normally roll back so they look like low radiances) and I'm curious if ABI has the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In this PR, we aim to provide satpy the ability to clip negative radiances (i.e of ABI)
AUTHORS.md
if not there alreadyRelated to: