Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings from NWCSAF reader #2510

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

ninahakansson
Copy link
Contributor

@ninahakansson ninahakansson commented Jun 14, 2023

Added ancillary datasets to nwcsaf-pps yaml file. This will remove the warnings of this type:

[2023-06-12 12:58:33,423 WARNING  satpy.readers.yaml_reader] Can't load ancillary dataset cmic_dcwp 
  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

This will remove the warnings:

[2023-06-12 12:58:33,423 WARNING  satpy.readers.yaml_reader] Can't load ancillary dataset cmic_dcwp
[2023-06-12 12:58:33,424 WARNING  satpy.readers.yaml_reader] Can't load ancillary dataset cmic_dcwp
[2023-06-12 12:58:33,425 WARNING  satpy.readers.yaml_reader] Can't load ancillary dataset cmic_dcot
[2023-06-12 12:58:33,426 WARNING  satpy.readers.yaml_reader] Can't load ancillary dataset cma_conditions
[2023-06-12 12:58:33,427 WARNING  satpy.readers.yaml_reader] Can't load ancillary dataset cma_quality
[2023-06-12 12:58:33,428 WARNING  satpy.readers.yaml_reader] Can't load ancillary dataset cma_status_flag
[2023-06-12 12:58:33,429 WARNING  satpy.readers.yaml_reader] Can't load ancillary dataset cmic_dcwp
[2023-06-12 12:58:33,431 WARNING  satpy.readers.yaml_reader] Can't load ancillary dataset cmic_dcre
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #2510 (502efc8) into main (fffc661) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2510   +/-   ##
=======================================
  Coverage   94.85%   94.85%           
=======================================
  Files         337      337           
  Lines       49624    49624           
=======================================
  Hits        47069    47069           
  Misses       2555     2555           
Flag Coverage Δ
behaviourtests 4.41% <ø> (ø)
unittests 95.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5267108512

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.419%

Totals Coverage Status
Change from base Build 5266393447: 0.0%
Covered Lines: 47182
Relevant Lines: 49447

💛 - Coveralls

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud added this to the v0.43.0 milestone Jun 14, 2023
@mraspaud mraspaud merged commit 36ae504 into pytroll:main Jun 14, 2023
@djhoese
Copy link
Member

djhoese commented Jun 16, 2023

Ah ha! @mraspaud you merged this when it had a pre-commit failure! @joleenf this is why your PR is complaining about it now.

@mraspaud
Copy link
Member

Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants