-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert CF Writer tests to pytest #2523
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2523 +/- ##
==========================================
- Coverage 94.96% 94.88% -0.09%
==========================================
Files 347 347
Lines 50921 50931 +10
==========================================
- Hits 48358 48326 -32
- Misses 2563 2605 +42
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
||
def test_collect_cf_dataarrays_with_latitude_named_lat(self, *mocks): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mocks not needed I guess ...
Pull Request Test Coverage Report for Build 5392538598
💛 - Coveralls |
@djhoese I think is ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. For the record, you could have used setup_method
instead of converting the fake datasets to fixtures, but I'm guessing you knew that. Thanks for cleaning this up. Let's merge it...
AUTHORS.md
if not there alreadyConvert CFWriter test units from unitest to pytest