New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement non-linear scaling for NDVI hybrid green correction #2554

Merged

mraspaud merged 7 commits into pytroll:main from strandgren:feature_nonlinear_ndvi_green_correction

Oct 10, 2023

Merged

Implement non-linear scaling for NDVI hybrid green correction #2554

Refactor unit tests for NDVI-weighted hybrid green correction.

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Sep 18, 2023 in 30s

CodeScene PR Check

✅ Quality Gates: OK

Declining Code Health: 1 findings(s) 🚩
Improving Code Health: 0 findings(s) ✅
Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene

Details

🚩 Negative Code Health Impact (highest to lowest):

Code Duplication test_spectral.py

Annotations

Check notice on line 157 in satpy/composites/spectral.py

codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Excess Number of Function Arguments

NDVIHybridGreen.__init__ increases from 5 to 6 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.

Check warning on line 78 in satpy/tests/compositor_tests/test_spectral.py

codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Code Duplication

The module contains 3 functions with similar structure: TestSpectralComposites.test_green_corrector,TestSpectralComposites.test_hybrid_green,TestSpectralComposites.test_spectral_blender. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.

View more details on CodeScene Delta Analysis