Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix geotiff and png writers to save to a temporary directory #257

Merged
merged 3 commits into from
Apr 19, 2018

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Apr 19, 2018

This was my mistake when I originally created these tests that the base_dir should have been specified in the writer init instead of the save_datasets method. This also adds bdist_wheel to the travis deployment. We'll see how that works next time we tag a release.

  • Tests added
  • Tests passed
  • Passes git diff origin/develop **/*py | flake8 --diff

@djhoese djhoese added this to the v0.9 milestone Apr 19, 2018
@djhoese djhoese self-assigned this Apr 19, 2018
@coveralls
Copy link

coveralls commented Apr 19, 2018

Coverage Status

Coverage decreased (-0.2%) to 63.888% when pulling 660937e on davidh-ssec:bugfix-tif-tests into 2dbb93a on pytroll:develop.

@codecov-io
Copy link

Codecov Report

Merging #257 into develop will decrease coverage by 0.18%.
The diff coverage is 92.59%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #257      +/-   ##
===========================================
- Coverage    64.06%   63.88%   -0.19%     
===========================================
  Files          112      112              
  Lines        13863    13879      +16     
===========================================
- Hits          8882     8867      -15     
- Misses        4981     5012      +31
Impacted Files Coverage Δ
satpy/tests/writer_tests/test_geotiff.py 95% <100%> (+0.66%) ⬆️
satpy/tests/writer_tests/test_simple_image.py 93.75% <81.81%> (-3.69%) ⬇️
satpy/writers/geotiff.py 38.88% <0%> (-33.34%) ⬇️
satpy/utils.py 57.94% <0%> (-1.87%) ⬇️
satpy/writers/__init__.py 73.85% <0%> (+3.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dbb93a...660937e. Read the comment docs.

@djhoese djhoese merged commit 9015169 into pytroll:develop Apr 19, 2018
@djhoese djhoese deleted the bugfix-tif-tests branch April 19, 2018 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants