Remove use of deprecated setuptools_scm_git_archive build package #2575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also think I can simplify the setup.py by removing a hack we had for setuptools_scm that I think is now not needed. |
1 task
Codecov Report
@@ Coverage Diff @@
## main #2575 +/- ##
=======================================
Coverage 94.91% 94.91%
=======================================
Files 351 351
Lines 51217 51217
=======================================
Hits 48613 48613
Misses 2604 2604
Flags with carried forward coverage won't be shown. Click here to find out more. |
mraspaud
approved these changes
Sep 21, 2023
|
Yeah let's merge it and see what happens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my Polar2Grid project I install Satpy from source. I noticed today that CI was failing because Satpy is still using the deprecated setuptools_scm_git_archive utility package. The functionality of this package has been merged into setuptools_scm and is no longer needed. It now fails because setuptools_scm (the newest version) no longer includes modules that that package was importing.
AUTHORS.mdif not there already