Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VGAC decode the time variable #2595

Merged
merged 18 commits into from
Mar 8, 2024
Merged

Conversation

ninahakansson
Copy link
Contributor

@ninahakansson ninahakansson commented Oct 10, 2023

Decode the time variable into a np.datetime64 variable. The time variable in VGAC need to be decoded in two steps. The time variable contains hours since proj_time0 for each scanline and the proj_time0 has the unit "days since 2010-01-01".

  • Tests added

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that's a messy datetime format they have in these files! Good job on sorting it out :)
Tests are missing obviously, but I also have a few comments/questions inline.

satpy/readers/viirs_vgac_l1c_nc.py Outdated Show resolved Hide resolved
satpy/readers/viirs_vgac_l1c_nc.py Outdated Show resolved Hide resolved
satpy/readers/viirs_vgac_l1c_nc.py Outdated Show resolved Hide resolved
satpy/readers/viirs_vgac_l1c_nc.py Outdated Show resolved Hide resolved
satpy/readers/viirs_vgac_l1c_nc.py Outdated Show resolved Hide resolved
Co-authored-by: Martin Raspaud <martin.raspaud@smhi.se>
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: Patch coverage is 98.43750% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.93%. Comparing base (ed751f8) to head (7e336ee).
Report is 4 commits behind head on main.

Files Patch % Lines
satpy/readers/viirs_vgac_l1c_nc.py 95.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2595   +/-   ##
=======================================
  Coverage   95.92%   95.93%           
=======================================
  Files         375      375           
  Lines       53167    53223   +56     
=======================================
+ Hits        51003    51058   +55     
- Misses       2164     2165    +1     
Flag Coverage Δ
behaviourtests 4.12% <0.00%> (-0.01%) ⬇️
unittests 96.02% <98.43%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Nina.Hakansson added 3 commits October 12, 2023 09:21
raise exception when units are not of expected format

Use um instead of ms for better accuracy
@ninahakansson ninahakansson marked this pull request as ready for review October 23, 2023 10:58
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 6c9d8b2 into pytroll:main Mar 8, 2024
17 of 19 checks passed
@mraspaud mraspaud added enhancement code enhancements, features, improvements component:readers labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants