-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VGAC decode the time variable #2595
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, that's a messy datetime format they have in these files! Good job on sorting it out :)
Tests are missing obviously, but I also have a few comments/questions inline.
Co-authored-by: Martin Raspaud <martin.raspaud@smhi.se>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2595 +/- ##
=======================================
Coverage 95.92% 95.93%
=======================================
Files 375 375
Lines 53167 53223 +56
=======================================
+ Hits 51003 51058 +55
- Misses 2164 2165 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
raise exception when units are not of expected format Use um instead of ms for better accuracy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The delta_full_days was before an array of size 1, now it is a scalar.
Decode the time variable into a np.datetime64 variable. The time variable in VGAC need to be decoded in two steps. The time variable contains hours since proj_time0 for each scanline and the proj_time0 has the unit "days since 2010-01-01".