Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to test Python 3.12 #2597

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Update CI to test Python 3.12 #2597

merged 1 commit into from
Feb 6, 2024

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Oct 10, 2023

As discussed in the monthly meeting. I chose to drop Python 3.10 tests so we still limit how many version we're testing.

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@djhoese
Copy link
Member Author

djhoese commented Oct 10, 2023

Looks like it needs Python 3.12 wheel for pyresample.

Nevermind, needs it in conda-forge.

@djhoese
Copy link
Member Author

djhoese commented Oct 29, 2023

Looks like we're waiting on numba and that's waiting on llvmlite. The related PR for that says they're waiting for their November release which should include support for Python 3.12.

@djhoese djhoese closed this Dec 8, 2023
@djhoese djhoese reopened this Dec 8, 2023
@cclauss
Copy link

cclauss commented Feb 3, 2024

https://pypi.org/project/llvmlite/ supports Py3.12
https://pypi.org/project/numba/ supports Py3.12

@djhoese
Copy link
Member Author

djhoese commented Feb 3, 2024

Oh trust me, I've been tracking all of that. I suppose theoretically I can probably just restart these CI jobs and see what happens. Oh I'll need to rebase with main...

@djhoese djhoese added the cleanup Code cleanup but otherwise no change in functionality label Feb 3, 2024
@djhoese
Copy link
Member Author

djhoese commented Feb 3, 2024

Looks like the conda-forge package for numba didn't have Python 3.12 builds enabled during the last PR merge. That is being fixed here: conda-forge/numba-feedstock#133

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fa4e426) 95.40% compared to head (4877082) 95.88%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2597      +/-   ##
==========================================
+ Coverage   95.40%   95.88%   +0.48%     
==========================================
  Files         371      371              
  Lines       52825    52825              
==========================================
+ Hits        50399    50653     +254     
+ Misses       2426     2172     -254     
Flag Coverage Δ
behaviourtests 4.15% <ø> (ø)
unittests 95.98% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7769033141

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.968%

Totals Coverage Status
Change from base Build 7758952336: 0.0%
Covered Lines: 50525
Relevant Lines: 52648

💛 - Coveralls

@djhoese
Copy link
Member Author

djhoese commented Feb 6, 2024

As mentioned in the monthly meeting we are fine merging this, but we've also passed the moment that Python 3.9 doesn't need to be supported according to:

https://scientific-python.org/specs/spec-0000/

I will make another PR today to drop Python 3.9 and others can comment there if they disagree with this.

@djhoese djhoese merged commit cd33a0a into pytroll:main Feb 6, 2024
18 of 19 checks passed
@djhoese djhoese deleted the ci-py312 branch February 6, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code cleanup but otherwise no change in functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants