remove setuptools_scm_git_archive from requirement #2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package's functionality is now found in setuptools_scm (see pytroll#2549 and https://github.com/Changaco/setuptools_scm_git_archive ). Minimal changes done: 1. Remove setuptools_scm_git_archive from setup.cfg and doc/rtd_environment.yml 2. Change the content of .git_archival.txt according to https://setuptools-scm.readthedocs.io/en/latest/usage/#builtin-mechanisms-for-obtaining-version-numbers fixes pytroll#2549
Codecov Report
@@ Coverage Diff @@
## main #2598 +/- ##
=======================================
Coverage 94.93% 94.93%
=======================================
Files 354 354
Lines 51401 51401
=======================================
Hits 48800 48800
Misses 2601 2601
Flags with carried forward coverage won't be shown. Click here to find out more. |
Pull Request Test Coverage Report for Build 6479992181
💛 - Coveralls |
djhoese
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
I made a one change to remove the setup_requires from the setup.cfg. This section should not have been used since we have a pyproject.toml now. Thanks for cleaning up the changes necessary to drop the old package. I didn't realize I hadn't completed them...but now you're making me worry I didn't do this correctly for other packages (in particular the .git_archival.txt changes).
When CI passes we can merge this. @mraspaud this should be merged before a release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package's functionality is now found in setuptools_scm (see #2549 and
https://github.com/Changaco/setuptools_scm_git_archive ).
Minimal changes done:
fixes #2549