-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some global EPSG 4326 gridded lat/lon areas. #2600
Conversation
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Re-order some of the area definitions.
I'm only now realizing that this can be achieved easily with: In [4]: AreaDefinition.from_epsg(4326, 0.1)
Out[4]:
Area ID: WGS 84
Description: WGS 84
Projection: {'datum': 'WGS84', 'no_defs': 'None', 'proj': 'longlat', 'type': 'crs'}
Number of columns: 3600
Number of rows: 1800
Area extent: (-180.0, -90.0, 180.0, 90.0) etc... |
Codecov Report
@@ Coverage Diff @@
## main #2600 +/- ##
==========================================
- Coverage 94.94% 94.92% -0.03%
==========================================
Files 354 354
Lines 51474 51474
==========================================
- Hits 48873 48862 -11
- Misses 2601 2612 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I'd like to point out that this could reveal some fun bugs in satpy and pyresample as technically speaking EPSG:4326 has (lat, lon) ordered axes rather than our usual (lon-x, lat-y) ordering. Pyresample is pretty good about asking pyproj to force x/y order, but I'm sure there are some spots that aren't doing it. Additionally, GDAL recommends not using 4326: https://gdal.org/user/coordinate_epoch.html#dynamic-crs-and-coordinate-epoch
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds some global EPSG:4326 area definitions for lat/lon grids at the following resolutions:
I chose these resolutions as they're ones that I've seen in common use and are hence those I think will be most useful across various use cases.