Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change platform name for EPIC (DSCOVR) to upper case. #2606

Merged
merged 2 commits into from
Oct 21, 2023

Conversation

simonrp84
Copy link
Member

In a recent pyspectral PR I added spectral response functions for EPIC. @adybbroe mentioned that the platform name in that PR should be upper case. The same is true in satpy, so here I make a PR to correct the platform name to the WMO standard name.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #2606 (58ddfaa) into main (34e2bd9) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2606   +/-   ##
=======================================
  Coverage   94.94%   94.94%           
=======================================
  Files         354      354           
  Lines       51474    51474           
=======================================
  Hits        48873    48873           
  Misses       2601     2601           
Flag Coverage Δ
behaviourtests 4.27% <0.00%> (ø)
unittests 95.56% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
satpy/readers/epic_l1b_h5.py 100.00% <100.00%> (ø)
satpy/tests/writer_tests/test_cf.py 95.53% <ø> (ø)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6589533562

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.514%

Totals Coverage Status
Change from base Build 6550698316: 0.0%
Covered Lines: 48996
Relevant Lines: 51297

💛 - Coveralls

@djhoese djhoese merged commit 3876475 into pytroll:main Oct 21, 2023
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants