Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy resampler code #2610

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Oct 23, 2023

Satpy depends on a new enough version of pyresample that all of theses imports are guaranteed.

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

Satpy depends on a new enough version of pyresample that all of theses imports are guaranteed.
@djhoese djhoese added enhancement code enhancements, features, improvements component:resampling cleanup Code cleanup but otherwise no change in functionality labels Oct 23, 2023
@djhoese djhoese self-assigned this Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #2610 (dc3ee7d) into main (0f339d1) will increase coverage by 0.12%.
The diff coverage is 100.00%.

❗ Current head dc3ee7d differs from pull request most recent head 59c8b94. Consider uploading reports for the commit 59c8b94 to get more accurate results

@@            Coverage Diff             @@
##             main    #2610      +/-   ##
==========================================
+ Coverage   94.94%   95.07%   +0.12%     
==========================================
  Files         354      354              
  Lines       51487    51370     -117     
==========================================
- Hits        48886    48839      -47     
+ Misses       2601     2531      -70     
Flag Coverage Δ
behaviourtests 4.23% <80.00%> (-0.04%) ⬇️
unittests 95.69% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
satpy/resample.py 89.32% <100.00%> (+9.52%) ⬆️

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6617341206

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 95.642%

Totals Coverage Status
Change from base Build 6614128955: 0.1%
Covered Lines: 48962
Relevant Lines: 51193

💛 - Coveralls

@djhoese
Copy link
Member Author

djhoese commented Oct 23, 2023

Oh I like the 0.1% increase in coverage 😉

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Nice with all the removed code!

@mraspaud mraspaud merged commit a497619 into pytroll:main Oct 23, 2023
8 of 18 checks passed
@djhoese
Copy link
Member Author

djhoese commented Oct 23, 2023

Oh no! I just pushed one more commit that failed tests lol. Shoot. New PR incoming... lol

Sorry, my fault for trying to throw in one more commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code cleanup but otherwise no change in functionality component:resampling enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants