Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nwcsaf_geo start time to be nominal time #2635

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

mraspaud
Copy link
Member

NWCSAF GEO file contain a different time for start of time coverage and nominal time. This PR makes the reader choose the nominal time when available.

  • Tests added

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #2635 (e43f3fa) into main (1e0cf20) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2635   +/-   ##
=======================================
  Coverage   95.20%   95.20%           
=======================================
  Files         354      354           
  Lines       51368    51374    +6     
=======================================
+ Hits        48906    48912    +6     
  Misses       2462     2462           
Flag Coverage Δ
behaviourtests 4.24% <0.00%> (-0.01%) ⬇️
unittests 95.83% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
satpy/readers/nwcsaf_nc.py 82.21% <100.00%> (+0.21%) ⬆️
satpy/tests/reader_tests/test_nwcsaf_nc.py 100.00% <100.00%> (ø)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6825204541

  • 10 of 10 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 95.783%

Totals Coverage Status
Change from base Build 6816647681: 0.001%
Covered Lines: 49038
Relevant Lines: 51197

💛 - Coveralls

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another way of looking at this PR is that it is fixing the reader to follow the standards for Satpy metadata defined here: https://satpy.readthedocs.io/en/latest/reading.html#time-metadata

I assume by your try/except that nominal time isn't always available? If that is the case then LGTM.

@mraspaud
Copy link
Member Author

Another way of looking at this PR is that it is fixing the reader to follow the standards for Satpy metadata defined here: https://satpy.readthedocs.io/en/latest/reading.html#time-metadata

I assume by your try/except that nominal time isn't always available? If that is the case then LGTM.

Yes exactly. This reader can handle files from two different software, where only one of them provides a nominal time. The other one doesn't need it as its about polar data.

@mraspaud mraspaud merged commit 35f9f96 into pytroll:main Nov 15, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants