Workaround AWIPS bug not handling integers properly in "awips_tiled" writer #2671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2671 +/- ##
=======================================
Coverage 95.31% 95.32%
=======================================
Files 371 371
Lines 52435 52435
=======================================
+ Hits 49980 49982 +2
+ Misses 2455 2453 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 7143636183
💛 - Coveralls |
|
Thanks for your help with this @djhoese! Just to be clear, this appears to be a bug in edex, the part of AWIPS the pre-processes data for display in the AWIPS visualization tool CAVE. There are probibly ways to work around this issue inside EDEX, but we can't seem to find anyone who can explain what is going on. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered by @spruceboy and the rest of the GINA team in Alaska. It seems AWIPS is fine displaying data that is unsigned 16-bit integers stored in a 16-bit signed integer with the
_Unsigned: trueattribute. However, AWIPS does like this data when using special "derivedParameters" functionality where it treats the data as signed data before passing it to additional processing. In an attempt workaround this issue @spruceboy tried saving the data as signed integers (no_Unsignedattribute) and that fixed the addition processing, but broke the visualization. The simplest fix for now (seeing as AWIPS development will take 6-12 months minimum once the fix is implemented) is in this PR which is to only use the positive side of the signed variable.Note: I had to update one of the tests because the precision of the saved NetCDF data compared to the original input data was reduced, BUT this PR is not fixing a Satpy bug. This PR is working around an AWIPS bug.
CC @kathys
AUTHORS.mdif not there already