Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xarray version in CF writer tests for compression kwarg #2674

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Dec 11, 2023

Yet another XArray release without the compression kwarg fix, so lets bump the version up a notch.

@pnuu pnuu self-assigned this Dec 11, 2023
@pnuu pnuu changed the title Update xarray version in compression tests for compression kwarg Update xarray version in CF writer tests for compression kwarg Dec 11, 2023
Copy link
Member

@sfinkens sfinkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fbe017c) 95.31% compared to head (aa98fd6) 95.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2674   +/-   ##
=======================================
  Coverage   95.31%   95.32%           
=======================================
  Files         371      371           
  Lines       52435    52435           
=======================================
+ Hits        49980    49982    +2     
+ Misses       2455     2453    -2     
Flag Coverage Δ
behaviourtests 4.16% <ø> (ø)
unittests 95.93% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7167995300

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.886%

Totals Coverage Status
Change from base Build 7106990647: 0.0%
Covered Lines: 50108
Relevant Lines: 52258

💛 - Coveralls

@pnuu pnuu merged commit d90acf5 into pytroll:main Dec 11, 2023
18 of 19 checks passed
@pnuu pnuu deleted the fix-test-cf-xarray-2023.12 branch December 11, 2023 13:40
@pnuu pnuu mentioned this pull request Dec 12, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants