-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CF encoding of dataset attributes public #2675
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2675 +/- ##
=======================================
Coverage 95.30% 95.30%
=======================================
Files 371 371
Lines 52435 52435
=======================================
Hits 49971 49971
Misses 2464 2464
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 7168333052
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine merging this, but just so we're sure we're not missing some feature or other use case here, @sfinkens could you provide more information about your use case? Are you using xarray? What makes you need this lower-level function versus the higher-level ones that call it?
Sure! I have an algorithm that returns an xarray dataset, which I want to save to disk. The dataset's
The higher-level method would be |
Good point on the preprocess function. Makes sense. |
In some of my projects I have been using
satpy.writer.encode_attrs_nc
, which has been made private in Satpy 0.45. This is an attempt to get it back 🙂Also, xarray still doesn't support theSolved by Panucompression
kwarg, so I bumped the anticipated version number by two months.