Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MiRS reader coefficient files to newer version #2679

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Dec 11, 2023

We got new versions of the coefficients. This PR updates the versions used by the reader to the new versions I uploaded to zenodo.

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@djhoese djhoese added enhancement code enhancements, features, improvements component:readers labels Dec 11, 2023
@djhoese djhoese self-assigned this Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a5003a5) 95.32% compared to head (8c79995) 95.32%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2679   +/-   ##
=======================================
  Coverage   95.32%   95.32%           
=======================================
  Files         371      371           
  Lines       52435    52435           
=======================================
  Hits        49982    49982           
  Misses       2453     2453           
Flag Coverage Δ
behaviourtests 4.16% <ø> (ø)
unittests 95.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7173614789

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.886%

Totals Coverage Status
Change from base Build 7170941492: 0.0%
Covered Lines: 50108
Relevant Lines: 52258

💛 - Coveralls

Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djhoese djhoese merged commit c5c18cf into pytroll:main Dec 12, 2023
18 of 19 checks passed
@djhoese djhoese deleted the mirs-new-coeffs branch December 12, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
Development

Successfully merging this pull request may close these issues.

3 participants