-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of warnings in resampler tests #2681
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2681 +/- ##
==========================================
- Coverage 95.32% 95.32% -0.01%
==========================================
Files 371 371
Lines 52435 52398 -37
==========================================
- Hits 49982 49946 -36
+ Misses 2453 2452 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 7209266780Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
from pyresample.ewa import DaskEWAResampler, LegacyDaskEWAResampler | ||
from pyresample.geometry import SwathDefinition | ||
from pyresample.gradient import GradientSearchResampler | ||
from pyresample.gradient import create_gradient_search_resampler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The module docstring still uses the class. If it shouldn't, could you update it to point to this function too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting this! Fixed in 1bb5655
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made one comment about the docstring. Besides that this looks good to go. Thanks!
This PR adjusts the resamplers so that the tests do not issue any warnings.
Also warning from import gradient search is handled. This is not visible in the tests, but I've seen this in real usage.