-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AHI HSD reader to correctly handle singleton arrays. #2682
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2682 +/- ##
=======================================
Coverage 95.32% 95.32%
=======================================
Files 371 371
Lines 52441 52441
=======================================
Hits 49988 49988
Misses 2453 2453
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 7183035793
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thanks a lot!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ooops, I messed up the tests. Should be fixed now. |
Recently, one of the libraries used by satpy (I think numpy) has started warning about conversion of arrays to scalar:
This PR updates the
ahi_hsd
reader and tests to remove the warning by selecting the first element of the relevant array. As the array only has one element, this means there's no change in any results on the user-side.