-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fci/l2/amv/reader #2683
Fci/l2/amv/reader #2683
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2683 +/- ##
==========================================
+ Coverage 95.31% 95.35% +0.03%
==========================================
Files 371 371
Lines 52435 52464 +29
==========================================
+ Hits 49980 50028 +48
+ Misses 2455 2436 -19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 7210821644Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice PR, thanks for putting it up! Some comments and questions inline.
Co-authored-by: Martin Raspaud <martin.raspaud@smhi.se>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR add a reader for the FCI L2 AMV.
Since the AMV products are NetCDF files that only use 1 dimension (
number_of_winds
) to define all the variables.It need a dedicated File Handler to avoid adding exception handler for non-array stuff like x and y.
This File handler inherit
FciL2CommonFunctions
and only modify a couple of methods including the get_dataset.It is rather simple and does not process the data.
There is no Area definition since the product does not contain any.
Only the lat,lon needs to be used to project and display the AMV on a map.