Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QC-based filtering to the VIIRS EDR AOD550 product #2714

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Jan 5, 2024

See ssec/polar2grid#666 for more information. Basically the AOD ("AOD550") product from the VIIRS EDR files looks a little "not good" by default. @kathys and I would like to play around with filtering it based on the QCAll QC variable in the file.

@kathys I think as a starting point maybe you could point me to some data files of a good test case and I could generate images for all of the QC cases (0, 1, 2, 3 - default) and we see which looks best. I don't think it necessarily matters what Satpy uses in this PR as I've turned it off by default with the general practice Satpy has of not interfering with data coming from the files.

  • Tests added
  • Fully documented

@djhoese djhoese added enhancement code enhancements, features, improvements component:readers labels Jan 5, 2024
@djhoese djhoese self-assigned this Jan 5, 2024
@djhoese djhoese requested a review from mraspaud as a code owner January 5, 2024 20:06
@kathys
Copy link

kathys commented Jan 5, 2024

@djhoese. A good test data set is here: bumi:/data/users/kathys/test_data/viirs_edr/j01/summer/asci/.

See image here: ssec/polar2grid#666

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (afb4049) 95.39% compared to head (9d8b2fd) 95.40%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2714   +/-   ##
=======================================
  Coverage   95.39%   95.40%           
=======================================
  Files         371      371           
  Lines       52691    52749   +58     
=======================================
+ Hits        50265    50323   +58     
  Misses       2426     2426           
Flag Coverage Δ
behaviourtests 4.16% <0.00%> (-0.01%) ⬇️
unittests 96.01% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Jan 5, 2024

Pull Request Test Coverage Report for Build 7469837169

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 95.962%

Totals Coverage Status
Change from base Build 7416976545: 0.005%
Covered Lines: 50449
Relevant Lines: 52572

💛 - Coveralls

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question inline. Also please ping me when this is finished from the p2g standpoint.

satpy/readers/viirs_edr.py Show resolved Hide resolved
@djhoese
Copy link
Member Author

djhoese commented Jan 10, 2024

@mraspaud I commented on your question. Otherwise I think this is ready to go with the small fix I just committed.

@djhoese
Copy link
Member Author

djhoese commented Jan 10, 2024

Polar2Grid PR: ssec/polar2grid#674

@mraspaud mraspaud merged commit 07a448e into pytroll:main Jan 10, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants