-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the MERSI-RM instrument on FY-3G #2720
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2720 +/- ##
=======================================
Coverage 95.92% 95.92%
=======================================
Files 375 375
Lines 53100 53167 +67
=======================================
+ Hits 50936 51003 +67
Misses 2164 2164
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 7985771067Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for adding support for the RM.
Co-authored-by: Martin Raspaud <martin.raspaud@smhi.se>
This PR adds support for the MERSI-RM instrument aboard Fengyun-3G.
Unfortunately it's quite a different instrument to MERSI-2 and MERSI-LL so the existing YAMLs couldn't be reused. Luckily, the actual python code requires minimal change.