Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the MERSI-RM instrument on FY-3G #2720

Merged
merged 7 commits into from
Feb 21, 2024
Merged

Conversation

simonrp84
Copy link
Member

@simonrp84 simonrp84 commented Jan 12, 2024

This PR adds support for the MERSI-RM instrument aboard Fengyun-3G.
Unfortunately it's quite a different instrument to MERSI-2 and MERSI-LL so the existing YAMLs couldn't be reused. Luckily, the actual python code requires minimal change.

  • Tests added

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5320bca) 95.92% compared to head (ed751f8) 95.92%.
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2720   +/-   ##
=======================================
  Coverage   95.92%   95.92%           
=======================================
  Files         375      375           
  Lines       53100    53167   +67     
=======================================
+ Hits        50936    51003   +67     
  Misses       2164     2164           
Flag Coverage Δ
behaviourtests 4.13% <0.00%> (-0.01%) ⬇️
unittests 96.02% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Jan 12, 2024

Pull Request Test Coverage Report for Build 7985771067

Details

  • 0 of 74 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 96.009%

Totals Coverage Status
Change from base Build 7978811481: 0.005%
Covered Lines: 50875
Relevant Lines: 52990

💛 - Coveralls

@mraspaud mraspaud added the enhancement code enhancements, features, improvements label Feb 21, 2024
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding support for the RM.

simonrp84 and others added 2 commits February 21, 2024 08:59
Co-authored-by: Martin Raspaud <martin.raspaud@smhi.se>
@mraspaud mraspaud merged commit c79b387 into pytroll:main Feb 21, 2024
17 of 19 checks passed
@simonrp84 simonrp84 deleted the fy3g branch February 21, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants