Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nominal time attributes in SEVIRI HRIT #2743

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

sfinkens
Copy link
Member

Fix nominal_start/end_time attributes in SEVIRI HRIT, which were tuples due to a trailing comma.

  • Tests added

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4877082) 95.88% compared to head (f8937d4) 95.89%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2743   +/-   ##
=======================================
  Coverage   95.88%   95.89%           
=======================================
  Files         371      371           
  Lines       52825    52825           
=======================================
+ Hits        50653    50656    +3     
+ Misses       2172     2169    -3     
Flag Coverage Δ
behaviourtests 4.15% <33.33%> (ø)
unittests 95.99% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7901641731

Details

  • 0 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on fix-seviri-nominal-time at 95.973%

Totals Coverage Status
Change from base Build 7801990864: 96.0%
Covered Lines: 50528
Relevant Lines: 52648

💛 - Coveralls

@sfinkens sfinkens marked this pull request as ready for review February 14, 2024 13:38
@djhoese
Copy link
Member

djhoese commented Feb 14, 2024

Someone more involved in SEVIRI reader development (including @sfinkens) can merge this. I don't feel comfortable doing it.

Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pnuu pnuu merged commit e2153ab into pytroll:main Feb 15, 2024
18 of 19 checks passed
@sfinkens sfinkens deleted the fix-seviri-nominal-time branch October 18, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants