Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing defusedxml #2761

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Conversation

fwfichtner
Copy link
Contributor

  • adds defusedxml to msi_reader extra
  • adds new extra avhrr_l1b_eps because it was also missing defusedxml

Feel free to cherry-pick if you don't like the new reader.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for stepping in! One thing though, could you add your name to the authors file?

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.92%. Comparing base (85d9117) to head (45f918e).
Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2761      +/-   ##
==========================================
- Coverage   95.94%   95.92%   -0.03%     
==========================================
  Files         375      377       +2     
  Lines       53293    53468     +175     
==========================================
+ Hits        51130    51287     +157     
- Misses       2163     2181      +18     
Flag Coverage Δ
behaviourtests 4.11% <ø> (-0.02%) ⬇️
unittests 96.01% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Mar 14, 2024

Pull Request Test Coverage Report for Build 8278663645

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.999%

Totals Coverage Status
Change from base Build 8205996229: 0.0%
Covered Lines: 51159
Relevant Lines: 53291

💛 - Coveralls

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit aed88ce into pytroll:main Mar 14, 2024
17 of 19 checks passed
@fwfichtner fwfichtner deleted the add-missing-defusedxml branch March 14, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'defusedxml' missing in "msi_safe" extras
3 participants