-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for EO-SIP AVHRR LAC data #2762
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2762 +/- ##
=======================================
Coverage 95.92% 95.92%
=======================================
Files 377 377
Lines 53468 53489 +21
=======================================
+ Hits 51287 51310 +23
+ Misses 2181 2179 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 8348304532Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 The logic for finding the reader class, sensor etc could be moved to a separate method, otherwise looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR fixes a couple of things in the avhrr gaclac reader to accept EO-SIP (ESA) format LAC data
AUTHORS.md
if not there already