Replace setup with pyproject.toml

[mraspaud]

This PR removes setup.[py,cfg] and fills up pyproject.toml instead.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.89%. Comparing base (5ffe15e) to head (8a54645).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2763      +/-   ##
==========================================
- Coverage   95.92%   95.89%   -0.03%     
==========================================
  Files         377      377              
  Lines       53489    53488       -1     
==========================================
- Hits        51310    51293      -17     
- Misses       2179     2195      +16     

Flag	Coverage Δ
behaviourtests	4.09% <ø> (-0.01%)	⬇️
unittests	95.99% <ø> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coveralls]

Pull Request Test Coverage Report for Build 8357659803

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-96.0%) to 0.0%

---

Totals
Change from base Build 8350021041:	-96.0%
Covered Lines:	0
Relevant Lines:	0

---

💛 - Coveralls

[djhoese]

It should also be noted this switches the build system to use hatchling instead of setuptools. If you haven't already, please review other uses throughout the repository of setuptools-scm. For example it is needed to install unstable dependencies here:

satpy/.github/workflows/ci.yaml

Line 71 in 8527311

python -m pip install versioneer extension-helpers setuptools-scm configobj pkgconfig

But this isn't for satpy, but likely other pytroll packages that we depend on that use setuptools-scm during the build process.

@mraspaud does hatch-vcs default to the same versioning for dev/dirty environments? Not that it matters much, just curious.

[djhoese]

Oh and is hatch defaulting to finding the v* prefixed tags?

[mraspaud]

Oh and is hatch defaulting to finding the v* prefixed tags?

Yes it does if my regex isn't too rusty https://github.com/pypa/setuptools_scm/blob/v6.4.0/src/setuptools_scm/config.py#L13

[djhoese]

That's a setuptools scm file, not hatch, right?

[mraspaud]

That's a setuptools scm file, not hatch, right?

Yes, it is, but setuptools-scm is a dependency of hatch-vcs :)

[mraspaud]

It should also be noted this switches the build system to use hatchling instead of setuptools. If you haven't already, please review other uses throughout the repository of setuptools-scm. For example it is needed to install unstable dependencies here:

satpy/.github/workflows/ci.yaml

Line 71 in 8527311

python -m pip install versioneer extension-helpers setuptools-scm configobj pkgconfig

But this isn't for satpy, but likely other pytroll packages that we depend on that use setuptools-scm during the build process.

Yes, just for the unstable build, this seemed correct to me.

There is another mention of setuptools_scm in the rtd_environment.yml file, but as far as I can see that yaml file isn't used anywhere, so my assumption was that we are good.

@mraspaud does hatch-vcs default to the same versioning for dev/dirty environments? Not that it matters much, just curious.

the version number looks very similar for dev situations indeed, except that the date is also appended. See the screen capture here.

[djhoese]

That RTD environment file is used by RTD and is configured here:

satpy/.readthedocs.yml

Line 22 in 8527311

environment: doc/rtd_environment.yml

[mraspaud]

That RTD environment file is used by RTD and is configured here:

satpy/.readthedocs.yml

Line 22 in 8527311

environment: doc/rtd_environment.yml

indeed! The rtd build seems to be working, so I suspect there is not need to add anything.

[mraspaud]

@djhoese ok merging this?

[djhoese]

Yes I think so. Go for it.

[djhoese]

Darn it @mraspaud. This is why coveralls is broken. The coverage config never got transferred to pyproject.toml. Fixing now...

[mraspaud]

Sorry