Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the viirs EDR tests for newer xarray #2774

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Apr 2, 2024

This PR fixes the Viirs EDR tests for new xarray.

Dtype checks were failing because of the test file generation was being given float64 scale and offset parameters to the encoding.

@mraspaud mraspaud added the bug label Apr 2, 2024
@mraspaud mraspaud self-assigned this Apr 2, 2024
@mraspaud mraspaud requested a review from djhoese as a code owner April 2, 2024 14:34
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.92%. Comparing base (3aa2f79) to head (24109a1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2774   +/-   ##
=======================================
  Coverage   95.92%   95.92%           
=======================================
  Files         377      377           
  Lines       53535    53535           
=======================================
  Hits        51356    51356           
  Misses       2179     2179           
Flag Coverage Δ
behaviourtests 4.10% <0.00%> (ø)
unittests 96.02% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8524637244

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.008%

Totals Coverage Status
Change from base Build 8450068387: 0.0%
Covered Lines: 51228
Relevant Lines: 53358

💛 - Coveralls

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense for why this was an issue as the reader uses auto mask and scale from xarray/netcdf4-python:

mask_and_scale=True,

Thanks for fixing this.

@mraspaud mraspaud merged commit 7279b01 into pytroll:main Apr 2, 2024
18 of 19 checks passed
@mraspaud mraspaud deleted the fix-viirs-edr-tests branch April 2, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants