Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove doc references to setup.py #2786

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Apr 22, 2024

This PR removes outdated references to setup.py.

@mraspaud mraspaud added this to the v0.48.0 milestone Apr 22, 2024
@mraspaud mraspaud requested a review from ameraner April 22, 2024 06:51
@mraspaud mraspaud self-assigned this Apr 22, 2024
@mraspaud mraspaud requested a review from djhoese as a code owner April 22, 2024 06:51
Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.94%. Comparing base (05fdcbf) to head (87d072d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2786   +/-   ##
=======================================
  Coverage   95.94%   95.94%           
=======================================
  Files         379      379           
  Lines       53693    53693           
=======================================
  Hits        51515    51515           
  Misses       2178     2178           
Flag Coverage Δ
behaviourtests 4.09% <ø> (ø)
unittests 96.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8779757089

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 8779608590: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

Copy link
Member

@ameraner ameraner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@mraspaud mraspaud merged commit 294c3d7 into pytroll:main Apr 22, 2024
18 of 19 checks passed
@mraspaud mraspaud deleted the fix-doc-setup.py branch April 22, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation points to missing setup.py
4 participants