Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ABI L2 datasets when unitless and no calibration #2794

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Apr 25, 2024

Simple fix to handle the case of non-reflectance data triggering a KeyError. See #2765.

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.95%. Comparing base (87d072d) to head (c9aabb7).
Report is 20 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2794    +/-   ##
========================================
  Coverage   95.94%   95.95%            
========================================
  Files         379      379            
  Lines       53693    53861   +168     
========================================
+ Hits        51515    51680   +165     
- Misses       2178     2181     +3     
Flag Coverage Δ
behaviourtests 4.09% <0.00%> (-0.01%) ⬇️
unittests 96.04% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djhoese djhoese merged commit 4c28f9c into pytroll:main Apr 29, 2024
18 of 19 checks passed
@djhoese djhoese deleted the bugfix-abi-l2-calibration branch April 29, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

abi_l2_nc reader Key Error 'calibration' when trying to load Mask from fire Hot Spot
1 participant