Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing coverage configuration section to pyproject.toml #2797

Merged
merged 11 commits into from
May 9, 2024

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented May 5, 2024

CI was failing to upload coveralls for two reasons:

  1. When we moved to pyproject.toml one of the config sections regarding coverage was forgotten.
  2. A new security feature in git was causing the coveralls action to fail. I've fixed this upstream.
  • Closes #xxxx
  • Tests added
  • Fully documented

Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.95%. Comparing base (c9aabb7) to head (1742616).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2797   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files         379      379           
  Lines       53861    53861           
=======================================
  Hits        51680    51680           
  Misses       2181     2181           
Flag Coverage Δ
behaviourtests 4.09% <ø> (ø)
unittests 96.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djhoese djhoese marked this pull request as ready for review May 9, 2024 14:50
@djhoese djhoese requested a review from mraspaud as a code owner May 9, 2024 14:50
@djhoese djhoese added the cleanup Code cleanup but otherwise no change in functionality label May 9, 2024
@djhoese djhoese changed the title Fix coveralls upload in CI Add missing coverage configuration section to pyproject.toml May 9, 2024
@djhoese djhoese merged commit a2a6a10 into pytroll:main May 9, 2024
18 of 19 checks passed
@djhoese djhoese deleted the ci-coveralls-git-fix branch May 9, 2024 15:23
@mraspaud
Copy link
Member

Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code cleanup but otherwise no change in functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants