-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix uniqueness of hdf5-based dask arrays #2818
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2818 +/- ##
==========================================
- Coverage 95.95% 95.94% -0.01%
==========================================
Files 368 366 -2
Lines 53692 53518 -174
==========================================
- Hits 51518 51346 -172
+ Misses 2174 2172 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 9499281255Details
💛 - Coveralls |
We also now use tokenize and automatic chunk sizes
Windows environment was failing for seemingly unrelated reasons. Restarted... |
Pull Request Test Coverage Report for Build 9579385362Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can tell this looks good to me. Feel free to merge.
This PR makes sure that the same hdf5 dataset read from the same file yields the same dask array (name).